----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37247/#review96549 -----------------------------------------------------------
src/Makefile.am (line 402) <https://reviews.apache.org/r/37247/#comment152020> Tab spacing / hard tabs. src/Makefile.am (line 446) <https://reviews.apache.org/r/37247/#comment152021> Tab spacing / hard-tabs! src/Makefile.am <https://reviews.apache.org/r/37247/#comment152022> Why did you kill this line? src/Makefile.am (line 729) <https://reviews.apache.org/r/37247/#comment152023> Spacing / hard-tabs! src/Makefile.am (lines 755 - 758) <https://reviews.apache.org/r/37247/#comment152024> Spacing / hard-tabs! src/messages/docker_provisioner.proto (lines 25 - 26) <https://reviews.apache.org/r/37247/#comment152026> s/layerId/layer id/ src/slave/containerizer/provisioners/docker/reference_store.hpp (line 26) <https://reviews.apache.org/r/37247/#comment152027> Kill this blank line please. src/slave/containerizer/provisioners/docker/reference_store.hpp (line 28) <https://reviews.apache.org/r/37247/#comment152029> Missing ``` #include <process/process.hpp> ``` (for ProcessBase) src/slave/containerizer/provisioners/docker/reference_store.hpp (line 30) <https://reviews.apache.org/r/37247/#comment152028> Missing ``` #include <stout/option.hpp> ``` src/slave/containerizer/provisioners/docker/reference_store.hpp (line 32) <https://reviews.apache.org/r/37247/#comment152030> Missing ``` #include <stout/try.hpp> ``` src/slave/containerizer/provisioners/docker/reference_store.cpp (line 42) <https://reviews.apache.org/r/37247/#comment152034> This appears a bit overblown for the amount of symbols you are actually using from that namespace. src/slave/containerizer/provisioners/docker/reference_store.cpp (line 59) <https://reviews.apache.org/r/37247/#comment152039> Blank line here please. src/slave/containerizer/provisioners/docker/reference_store.cpp (line 65) <https://reviews.apache.org/r/37247/#comment152038> Blank line here please. src/slave/containerizer/provisioners/docker/reference_store.cpp (line 71) <https://reviews.apache.org/r/37247/#comment152037> Blank line here please. src/slave/containerizer/provisioners/docker/reference_store.cpp (line 76) <https://reviews.apache.org/r/37247/#comment152036> Blank line here please. src/slave/containerizer/provisioners/docker/reference_store.cpp (line 84) <https://reviews.apache.org/r/37247/#comment152040> Blank line here please. src/slave/containerizer/provisioners/docker/reference_store.cpp (line 93) <https://reviews.apache.org/r/37247/#comment152035> Blank line here please. src/slave/containerizer/provisioners/docker/store.cpp (line 100) <https://reviews.apache.org/r/37247/#comment152042> Blank line here please. src/slave/containerizer/provisioners/docker/store.cpp (line 107) <https://reviews.apache.org/r/37247/#comment152041> Blank line here please. - Till Toenshoff On Aug. 25, 2015, 9 p.m., Lily Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37247/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2015, 9 p.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-3021 > https://issues.apache.org/jira/browse/MESOS-3021 > > > Repository: mesos > > > Description > ------- > > Added Docker image reference store. > > > Diffs > ----- > > src/Makefile.am 571e1ac0f96b2452797a478680b540f2aab63aab > src/messages/docker_provisioner.hpp PRE-CREATION > src/messages/docker_provisioner.proto PRE-CREATION > src/slave/containerizer/provisioners/docker/reference_store.hpp > PRE-CREATION > src/slave/containerizer/provisioners/docker/reference_store.cpp > PRE-CREATION > src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/37247/diff/ > > > Testing > ------- > > make check > > Tests will be added in a later review. > > > Thanks, > > Lily Chen > >
