----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37427/#review95238 -----------------------------------------------------------
src/slave/containerizer/provisioners/docker/token_manager.hpp (line 51) <https://reviews.apache.org/r/37427/#comment150088> space between // and TODO src/slave/containerizer/provisioners/docker/token_manager.hpp (line 53) <https://reviews.apache.org/r/37427/#comment150087> Do javadoc style comments begin with "/**" ? I think the same would apply to other javadoc style comments throughout src/slave/containerizer/provisioners/docker/token_manager.cpp (lines 37 - 46) <https://reviews.apache.org/r/37427/#comment150097> no need to put underscore in front of parameters being passed in src/slave/containerizer/provisioners/docker/token_manager.cpp (line 135) <https://reviews.apache.org/r/37427/#comment150095> space between ) and { src/slave/containerizer/provisioners/docker/token_manager.cpp (line 230) <https://reviews.apache.org/r/37427/#comment150093> pass in token by const reference? src/slave/containerizer/provisioners/docker/token_manager.cpp (line 252) <https://reviews.apache.org/r/37427/#comment150094> space between () {}, you could also probably just do this in the header file src/tests/containerizer/docker_containerizer_tests.cpp (line 2998) <https://reviews.apache.org/r/37427/#comment150089> DockerContainerizerTest tests the Docker Containerizer. The TokenManager is a component of the Mesos Containerizer, and would therefore be a part of a Docker provisioner test file. - Lily Chen On Aug. 13, 2015, 4:47 a.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37427/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2015, 4:47 a.m.) > > > Review request for mesos, Lily Chen and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Changes: > - Added Token implementation (RFC 7519). > - Added TokenManager implementation. This component keeps a cache of tokens > requested for any future requests. > > > Diffs > ----- > > src/Makefile.am 111aed92820689b12ee4073269ce34db7be30960 > src/slave/containerizer/provisioners/docker/token_manager.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker/token_manager.cpp PRE-CREATION > src/tests/containerizer/docker_containerizer_tests.cpp > c8c27a64c06cf37bdaa5b474ea25bd2e971c8fea > > Diff: https://reviews.apache.org/r/37427/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >
