> On Aug. 8, 2015, 3:37 p.m., Guangya Liu wrote: > > So you will add some test cases in another RR?
This change should already be covered by existing tests. https://github.com/apache/mesos/blob/master/src/tests/scheduler_tests.cpp#L634 https://github.com/apache/mesos/blob/master/src/tests/fault_tolerance_tests.cpp#L520 - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37254/#review94633 ----------------------------------------------------------- On Aug. 8, 2015, 3:30 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37254/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2015, 3:30 p.m.) > > > Review request for mesos, Anand Mazumdar and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > Added Master::teardown() to make it consistent with how other calls are > handled. This also makes it easy to update the unregistered messages metric > in the subsequent review. > > > Diffs > ----- > > src/master/master.hpp b288b8a7ad84e49b3ca43966a4d20a64985aa98e > src/master/master.cpp 0330f94ad6fe6ac23061e5f45612133747b39a80 > > Diff: https://reviews.apache.org/r/37254/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
