-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711/#review94571
-----------------------------------------------------------
Bad patch!
Reviews applied: [35711]
Failed command: make -j3 distcheck
Error:
make dist-gzip am__post_remove_distdir='@:'
make[1]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot'
if test -d "mesos-0.24.0"; then find "mesos-0.24.0" -type d ! -perm -200 -exec
chmod u+w {} ';' && rm -rf "mesos-0.24.0" || { sleep 5 && rm -rf
"mesos-0.24.0"; }; else :; fi
test -d "mesos-0.24.0" || mkdir "mesos-0.24.0"
(cd 3rdparty && make top_distdir=../mesos-0.24.0
distdir=../mesos-0.24.0/3rdparty \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[2]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
(cd libprocess && make top_distdir=../../mesos-0.24.0
distdir=../../mesos-0.24.0/3rdparty/libprocess \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[3]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
:
test -d "../../mesos-0.24.0/3rdparty/libprocess" || mkdir
"../../mesos-0.24.0/3rdparty/libprocess"
(cd 3rdparty && make top_distdir=../../../mesos-0.24.0
distdir=../../../mesos-0.24.0/3rdparty/libprocess/3rdparty \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[4]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
(cd stout && make top_distdir=../../../../mesos-0.24.0
distdir=../../../../mesos-0.24.0/3rdparty/libprocess/3rdparty/stout \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[5]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout'
:
test -d "../../../../mesos-0.24.0/3rdparty/libprocess/3rdparty/stout" || mkdir
"../../../../mesos-0.24.0/3rdparty/libprocess/3rdparty/stout"
(cd include && make top_distdir=../../../../../mesos-0.24.0
distdir=../../../../../mesos-0.24.0/3rdparty/libprocess/3rdparty/stout/include \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[6]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout/include'
make[6]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout/include'
test -n ":" \
|| find "../../../../mesos-0.24.0/3rdparty/libprocess/3rdparty/stout"
-type d ! -perm -755 \
-exec chmod u+rwx,go+rx {} \; -o \
! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
! -type d ! -perm -400 -exec chmod a+r {} \; -o \
! -type d ! -perm -444 -exec /bin/bash
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout/install-sh
-c -m a+r {} {} \; \
|| chmod -R a+r
"../../../../mesos-0.24.0/3rdparty/libprocess/3rdparty/stout"
make[5]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout'
make[4]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
(cd include && make top_distdir=../../../mesos-0.24.0
distdir=../../../mesos-0.24.0/3rdparty/libprocess/include \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[4]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/include'
make[4]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/include'
test -n ":" \
|| find "../../mesos-0.24.0/3rdparty/libprocess" -type d ! -perm -755 \
-exec chmod u+rwx,go+rx {} \; -o \
! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
! -type d ! -perm -400 -exec chmod a+r {} \; -o \
! -type d ! -perm -444 -exec /bin/bash
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/install-sh
-c -m a+r {} {} \; \
|| chmod -R a+r "../../mesos-0.24.0/3rdparty/libprocess"
make[3]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
make[2]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
(cd src && make top_distdir=../mesos-0.24.0 distdir=../mesos-0.24.0/src \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[2]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
make[2]: *** No rule to make target `common/thread.cpp', needed by `distdir'.
Stop.
make[2]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
make[1]: *** [distdir] Error 1
make[1]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot'
make: *** [dist] Error 2
- Mesos ReviewBot
On Aug. 7, 2015, 3:48 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35711/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2015, 3:48 p.m.)
>
>
> Review request for mesos, Adam B, Jie Yu, and Michael Park.
>
>
> Bugs: MESOS-2210
> https://issues.apache.org/jira/browse/MESOS-2210
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Disallow special characters in role name.
>
>
> Diffs
> -----
>
> include/mesos/roles.hpp PRE-CREATION
> src/Makefile.am 35ebbbd0bd9c9dd059c02ce3dc22c780b929be81
> src/common/resources.cpp eb5476a0365fe65f474afd0ab7a52ad7f1e04521
> src/common/roles.cpp PRE-CREATION
> src/master/flags.cpp 60ac64d98d53f74f904846b27a3833a7c44a9756
> src/master/master.hpp b288b8a7ad84e49b3ca43966a4d20a64985aa98e
> src/master/master.cpp 0330f94ad6fe6ac23061e5f45612133747b39a80
> src/slave/flags.cpp 82b6cf47af26f0533ff603a67240777e9a9b986e
> src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56
> src/tests/roles_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35711/diff/
>
>
> Testing
> -------
>
> make -j8 check
>
>
> Thanks,
>
> haosdent huang
>
>
