> On Aug. 6, 2015, 10:26 p.m., Guangya Liu wrote: > > src/hdfs/hdfs.hpp, line 110 > > <https://reviews.apache.org/r/36979/diff/3/?file=1033647#file1033647line110> > > > > Why not use the following? > > > > return !out.get().empty();
Actually, that was exactly what I originally typed :) However, if you see the original code, the semantic is subtly different: it only checked for a non-zero exit code (which would be now guaranteed by the `! isError()`). So, changing as you suggest (which, incidentally, I agree on) would in fact require that the `version` command emits something non-trivial to stdout: as the method is sadly not commented, I don't know whether changing that would break existing code. I'll wait to hear what @BenH (or someone else more knowledgeable than me on this matter, at any rate) has to say. - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36979/#review94453 ----------------------------------------------------------- On Aug. 6, 2015, 6:24 p.m., Marco Massenzio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36979/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2015, 6:24 p.m.) > > > Review request for mesos, Benjamin Hindman and Artem Harutyunyan. > > > Bugs: MESOS-3142 > https://issues.apache.org/jira/browse/MESOS-3142 > > > Repository: mesos > > > Description > ------- > > Updating all references to os::shell > For more details see MESOS-3142. > > > Diffs > ----- > > src/hdfs/hdfs.hpp a070c3200f0a0ac48ec86451749c7faf10c7f6a7 > src/master/main.cpp e05a472b86170eb26df26aaa4b65437fcdd413ce > src/slave/containerizer/isolators/network/port_mapping.cpp > 8244c345b84108af7fa18d20e71401d6e1a0aeb0 > src/tests/containerizer/isolator_tests.cpp > ff6e2b7e190a58a4809d6e71addb15dabe418e17 > src/tests/containerizer/port_mapping_tests.cpp > 4bee74acba2b1472c80cabbc9d0384bd04c543aa > > Diff: https://reviews.apache.org/r/36979/diff/ > > > Testing > ------- > > make check > *Note*: this patch fixes breakages introduce by the refactoring in: > https://reviews.apache.org/r/36978 > > > Thanks, > > Marco Massenzio > >
