----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36318/#review93331 -----------------------------------------------------------
Ship it! src/master/master.cpp (line 4841) <https://reviews.apache.org/r/36318/#comment147708> This needs to go up before we try to send a message (or SchedulerDriverEventTest.SubscribedSchedulerFailover fails). To be safe, I'll also remove the logic to drop when !connected, and just log a warning instead. - Ben Mahler On July 28, 2015, 3:47 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36318/ > ----------------------------------------------------------- > > (Updated July 28, 2015, 3:47 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Isabel Jimenez, Marco > Massenzio, and Vinod Kone. > > > Bugs: MESOS-2294 > https://issues.apache.org/jira/browse/MESOS-2294 > > > Repository: mesos > > > Description > ------- > > This change refactors the framework struct in master to introduce support for > http frameworks. > - pid becomes a optional field now in the framework struct. > - added optional fields for supporting http frameworks to the framework struct > > > Diffs > ----- > > src/common/http.hpp 765860fa7d0ce354320e9d293d09719be87efca0 > src/master/http.cpp 3a1598fad4db03e5f62fd4a6bd26b2bedeee4070 > src/master/master.hpp 2c924addfb4c52d3048ee6ded13ce638145cc93f > src/master/master.cpp a8a195df07b5a97fdba7dfc5f312bbfa85a0d510 > > Diff: https://reviews.apache.org/r/36318/diff/ > > > Testing > ------- > > make check + tests now go in a separate patch now. > > > Thanks, > > Anand Mazumdar > >
