> On July 27, 2015, 7:21 p.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp, line 142 > > <https://reviews.apache.org/r/36828/diff/2/?file=1022226#file1022226line142> > > > > Same comments here as previous reviews: use Latch instead of condition > > variables here.
This one is a little harder since Latch is in Libprocess! Shall we leave this one using synchronized for now? - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36828/#review93167 ----------------------------------------------------------- On July 27, 2015, 7:04 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36828/ > ----------------------------------------------------------- > > (Updated July 27, 2015, 7:04 a.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael > Park. > > > Bugs: MESOS-3118 > https://issues.apache.org/jira/browse/MESOS-3118 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp > 5d24f21f63433b8525370736dd630880d324ebeb > > Diff: https://reviews.apache.org/r/36828/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joris Van Remoortere > >
