----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36757/#review93049 -----------------------------------------------------------
Can you add (or at least make TODOs for) tests for the negative cases? http -> ssl socket, https -> raw socket. After the remaining open issues this should look pretty good. 3rdparty/libprocess/src/tests/ssl_tests.cpp (lines 1025 - 1029) <https://reviews.apache.org/r/36757/#comment147319> You're going to get rid of this anyway, but for future reference: please use full words for variable names e.g. `responseBuffer` - Joris Van Remoortere On July 24, 2015, 5:49 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36757/ > ----------------------------------------------------------- > > (Updated July 24, 2015, 5:49 p.m.) > > > Review request for mesos, Joris Van Remoortere and Timothy Chen. > > > Bugs: MESOS-3093 > https://issues.apache.org/jira/browse/MESOS-3093 > > > Repository: mesos > > > Description > ------- > > Current http implementation lacks a https interface. This change exposes > SSL socket for "https" URL scheme. > > JIRA: MESOS-3093 > > > Diffs > ----- > > 3rdparty/libprocess/src/http.cpp d1685799f4c53e067d0812e037e171324ee7195f > 3rdparty/libprocess/src/tests/ssl_tests.cpp > 2fe50601615b0bee57bd3e05dc9c932f93ca7477 > > Diff: https://reviews.apache.org/r/36757/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jojy Varghese > >
