-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36663/
-----------------------------------------------------------
(Updated July 24, 2015, 12:17 a.m.)
Review request for mesos, Anand Mazumdar and Vinod Kone.
Changes
-------
Added test against ZK.
Bugs: MESOS-2736
https://issues.apache.org/jira/browse/MESOS-2736
Repository: mesos
Description
-------
Added address field to MasterInfo
As part of the new HTTP API and the need to
provide a better interface for clients that
do not integrate libmesos, we provide the IP
address of the Leader Master in the information
that gets serialized (in JSON) to ZooKeeper.
This will eventually supersede the `ip`, `port`
and `hostname` fields that are currently in
MasterInfo an which cannot fully support IPv6
addresses.
Jira: MESOS-2736
Review: https://reviews.apache.org/r/36663
Diffs (updated)
-----
include/mesos/mesos.proto e015c81d5052214ef8207642e23b3892a6123c9a
src/common/protobuf_utils.cpp e0f82b53f5e106bbf4e21d6ac946df0fae821882
src/master/master.cpp bab04feaf238e51c4d50feb1d3a9c0735ec68fec
src/tests/master_contender_detector_tests.cpp
d7a3b46b2e437818631064ae34317e49c9aa3748
src/tests/master_tests.cpp 826f276317da2507cdf99b2f2e21a147444469d8
Diff: https://reviews.apache.org/r/36663/diff/
Testing
-------
make check
(also tested via [zk-mesos](https://github.com/massenz/zk-mesos) that the
information serialized to ZK is readable and as expected).
Also ran 2x 0.23 master builds against a 0.24 one with this patch applied;
getting both versions in turn to be Leader, and also ran a 0.23 Slave with a
0.24 Leader, and they all recognized each other.
Thanks,
Marco Massenzio
