-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36425/
-----------------------------------------------------------
(Updated July 22, 2015, 7:39 a.m.)
Review request for mesos, Benjamin Hindman and Cody Maloney.
Changes
-------
Updated to configuration doc
Bugs: MESOS-2902
https://issues.apache.org/jira/browse/MESOS-2902
Repository: mesos
Description
-------
Jira: MESOS-2902
It is sometimes useful to enable an external script to
configure the IP address the Mesos Master will bind to
on the server, where it's not desirable to set the
--ip flag and/or a "wrapper" script is not a viable option.
This patch adds a --ip_discovery_script to point to a local
script that will emit as its only output the IP address that
the Master will bind to: only spaces and newlines are allowed;
further, as we cannot use the `libprocess` sub-processing
facilities, we cannot timeout the script, should this block
for long times (or even forever).
This will conflict with the --ip flag, so if both set, we will fail
with an appropriate error message.
Diffs (updated)
-----
docs/configuration.md babbd2f67b32d4f317cfdf8bb87f8725917b0aca
src/master/main.cpp fd4de4d0d9c3e9617408022d10b5e161bdc911e1
Diff: https://reviews.apache.org/r/36425/diff/
Testing
-------
make check
also tested against a couple of simple scripts that emulate the three possible
cases: a valid IP; a bogus one; an error exit code.
Thanks,
Marco Massenzio
