----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36488/#review92122 -----------------------------------------------------------
Ship it! I can't see the jpg to see how you changed it, but the text looks great to me. Just a couple of minor things. docs/oversubscription.md (line 43) <https://reviews.apache.org/r/36488/#comment146059> "such as cpus i.e. cpu shares, bandwidth" - redundant; You should only have "such as" or "i.e." in this phrase. docs/oversubscription.md (line 90) <https://reviews.apache.org/r/36488/#comment146060> s/regular offers will just be sent/no revocable resources will be offered/ docs/oversubscription.md (lines 99 - 104) <https://reviews.apache.org/r/36488/#comment146061> Did this removed text go somewhere else? I can't find it anymore. Seemed useful. - Adam B On July 17, 2015, 1 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36488/ > ----------------------------------------------------------- > > (Updated July 17, 2015, 1 p.m.) > > > Review request for mesos, Adam B and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Added first draft of oversubscription user doc > > > Diffs > ----- > > docs/images/oversubscription-overview.jpg PRE-CREATION > docs/oversubscription.md PRE-CREATION > > Diff: https://reviews.apache.org/r/36488/diff/ > > > Testing > ------- > > Rendered at: > https://github.com/nqn/mesos/blob/niklas/oversubscription-user-doc/docs/oversubscription.md > > > Thanks, > > Niklas Nielsen > >
