> On July 15, 2015, 5:29 p.m., Ben Mahler wrote: > > It looks like this could benefit from a bit of documentation that mentions > > the protobuf ["union > > technique"](https://developers.google.com/protocol-buffers/docs/techniques#union).
added a comment on top of the matcher. > On July 15, 2015, 5:29 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/gmock.hpp, line 319 > > <https://reviews.apache.org/r/36461/diff/1/?file=1010275#file1010275line319> > > > > Anything preventing s/t/type/ ? > > > > Type in this context is a bit confusing since it sounds like the > > message type. > > > > Can we call this something like 'UnionMessageMatcher' and avoid using > > the overloaded word "type"? s/MessageTypeMatcher/UnionMessageMatcher/ s/t/unionType/ > On July 15, 2015, 5:29 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/gmock.hpp, line 322 > > <https://reviews.apache.org/r/36461/diff/1/?file=1010275#file1010275line322> > > > > Anything preventing s/n/message/? s/n/message/ - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36461/#review91757 ----------------------------------------------------------- On July 13, 2015, 11:55 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36461/ > ----------------------------------------------------------- > > (Updated July 13, 2015, 11:55 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2913 > https://issues.apache.org/jira/browse/MESOS-2913 > > > Repository: mesos > > > Description > ------- > > Needed these abstractions for capturing specific CALLs explicitly in > subsequent reviews. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/gmock.hpp > 0fd3f8cf06c9efd357fa7c933cc28d527855ac9a > > Diff: https://reviews.apache.org/r/36461/diff/ > > > Testing > ------- > > Tested in subsequent reviews. > > > Thanks, > > Vinod Kone > >
