----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36463/#review91762 -----------------------------------------------------------
src/sched/sched.cpp (lines 890 - 892) <https://reviews.apache.org/r/36463/#comment145397> Maybe a little comment that we aren't provided the slave id but that's ok? src/sched/sched.cpp (line 891) <https://reviews.apache.org/r/36463/#comment145386> Newline here or don't bother storing kill? src/tests/fault_tolerance_tests.cpp (lines 1359 - 1360) <https://reviews.apache.org/r/36463/#comment145388> Ditto here, do we need the mesos:: prefix? src/tests/master_tests.cpp (lines 545 - 547) <https://reviews.apache.org/r/36463/#comment145387> Hm.. is the mesos:: prefix needed? Looks like we can remove this comment, given it's not in the other test, and it just describes the line of code, yeah? - Ben Mahler On July 13, 2015, 11:58 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36463/ > ----------------------------------------------------------- > > (Updated July 13, 2015, 11:58 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2913 > https://issues.apache.org/jira/browse/MESOS-2913 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/sched/sched.cpp a748686dfc6bff39d81fd7adbd5cce88ddaaa73d > src/tests/fault_tolerance_tests.cpp > 1070ccf17f98f6b3800684a5edd6517d90631c3e > src/tests/master_tests.cpp 57721b788d0c70f4c6f5cc44d87465f52a70b6c2 > > Diff: https://reviews.apache.org/r/36463/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
