-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36318/
-----------------------------------------------------------
(Updated July 15, 2015, 4:56 a.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Isabel Jimenez, Marco
Massenzio, and Vinod Kone.
Changes
-------
Simplified the design as per benh's comments, now the FrameworkDriver class
just has an optional field "pipe" for http frameworks.
Bugs: MESOS-2294
https://issues.apache.org/jira/browse/MESOS-2294
Repository: mesos
Description (updated)
-------
This change lays the ground-work for the master's ability to stream events back
to the client. This review turned out a bit too large for my own liking but in
a nutshell, it just takes a subscribe request and puts a subscribed event back
on the stream.
Explanation of changes:
- Made a generic FrameworkDriver interface that the master now uses to
communicate with the frameworks instead of just invoking
send(framework->pid,...)
- FrameworkDriver can be of 2 types http, libprocess. An Optional member
variable is used to distinguiush between them.
- This still uses hard-coded http related constants. They can go away when
Isabel submits her validation change (36217)
- This change prefers use of using trailing under-scores as member variables
from the style guide.
Diffs (updated)
-----
src/common/protobuf_utils.hpp afe5a85d3f58eaabb16807253c5fcc07cabcf8e8
src/common/protobuf_utils.cpp 9ac81c38efd70f92c64a5865fa79fe516e84dd92
src/master/http.cpp 23a6d4bd2f60cb4a4ad463aea7cc032941578bdc
src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec
src/master/master.cpp b877676afa6f3833eb7d2fb06beeaa288bd8bd5d
src/tests/http_api_tests.cpp 64bbeb6699171e85a5be293919ad9f32ded0ebac
Diff: https://reviews.apache.org/r/36318/diff/
Testing
-------
make check + a simple test for subscribe call received a subscribed event back
on the stream.
Thanks,
Anand Mazumdar
