----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36378/#review91262 -----------------------------------------------------------
Thanks for taking on this for me! src/linux/perf.cpp (line 449) <https://reviews.apache.org/r/36378/#comment144554> Using Try as a function parameter feels a bit non-idiomatic to me, though I agree it's less code this way. src/linux/perf.cpp (line 459) <https://reviews.apache.org/r/36378/#comment144555> 2 lines above? other places too. src/linux/perf.cpp (lines 461 - 473) <https://reviews.apache.org/r/36378/#comment144557> This is great abstraction; I agree we should put it into stout. (maybe even have os::release just return canonicalized linux version?) src/linux/perf.cpp (lines 475 - 482) <https://reviews.apache.org/r/36378/#comment144558> I think using a hashmap as an intermediate type is more flexisible. Right now, the operation after 'extract' is the same for all versions, but we can make it version-dependent too in the future to support e.g. unit, running time, etc. - Chi Zhang On July 9, 2015, 11:08 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36378/ > ----------------------------------------------------------- > > (Updated July 9, 2015, 11:08 p.m.) > > > Review request for mesos, Ben Mahler, Chi Zhang, Ian Downes, and Cong Wang. > > > Bugs: MESOS-2834 > https://issues.apache.org/jira/browse/MESOS-2834 > > > Repository: mesos > > > Description > ------- > > Refactor Linux Performance monitor to handle changing 'perf stat' output > versions depending on kernel version. > > > Diffs > ----- > > src/linux/perf.cpp 697b75e846a43d4f106ad8f39a18882836d7dc02 > > Diff: https://reviews.apache.org/r/36378/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Paul Brett > >
