> On July 2, 2015, 12:51 p.m., Alexander Rukletsov wrote: > > src/tests/authorization_tests.cpp, lines 43-45 > > <https://reviews.apache.org/r/36050/diff/4/?file=998232#file998232line43> > > > > Let's format it according to `clang-format`: > > > > ``` > > typedef ::testing::Types<LocalAuthorizer, > > tests::Module<Authorizer, TestLocalAuthorizer>> > > AuthorizerTestTypes; > > ```
I find that a great readability improvement. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36050/#review90214 ----------------------------------------------------------- On July 2, 2015, 11:18 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36050/ > ----------------------------------------------------------- > > (Updated July 2, 2015, 11:18 p.m.) > > > Review request for mesos and Till Toenshoff. > > > Bugs: MESOS-2945 > https://issues.apache.org/jira/browse/MESOS-2945 > > > Repository: mesos > > > Description > ------- > > Adds a test authorizer module. > > Updates the authorization tests in order to perform typed tests on the > default authorizer implementation and on the test authorizer module. > > > Diffs > ----- > > src/Makefile.am addb63f615f16ae6b25f745b2e79fd9fc0e27851 > src/examples/test_authorizer_module.cpp PRE-CREATION > src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 > src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84 > src/tests/module.cpp 61d4753f0f098005f56dd4a24984e30405c32558 > > Diff: https://reviews.apache.org/r/36050/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
