> On July 2, 2015, 12:52 a.m., Paul Brett wrote: > > src/linux/perf.cpp, line 473 > > <https://reviews.apache.org/r/36114/diff/1/?file=997704#file997704line473> > > > > How about extract_post_linux_2_6_39 for the name?
I wanted it that too, but functions names need to be lowerCamerl per style guide. - Chi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36114/#review90180 ----------------------------------------------------------- On July 1, 2015, 10:44 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36114/ > ----------------------------------------------------------- > > (Updated July 1, 2015, 10:44 p.m.) > > > Review request for mesos, Ian Downes, Paul Brett, and Cong Wang. > > > Bugs: mesos-2834 > https://issues.apache.org/jira/browse/mesos-2834 > > > Repository: mesos > > > Description > ------- > > perf: added another extract function to support the new perf format after > v3.12. > > > Diffs > ----- > > src/linux/perf.cpp 697b75e846a43d4f106ad8f39a18882836d7dc02 > > Diff: https://reviews.apache.org/r/36114/diff/ > > > Testing > ------- > > > Thanks, > > Chi Zhang > >
