----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/#review90190 -----------------------------------------------------------
src/master/validation.cpp (line 80) <https://reviews.apache.org/r/36037/#comment143191> This check needs to go away. "Keep-Alive" is an intent by the client that it wants to re-use the connection for further use/pipelining. Even if the client does not set it, it just means it wants to bear the extra cost of setting up the connection everytime it makes the request. This "Keep-Alive" has nothing to do with your stream being kept alive by the server for an "infinite" time as is being made out by looking at the code. Hence , this along with the test that tests this validation behavior needs to be deleted. - Anand Mazumdar On July 2, 2015, 2:05 a.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36037/ > ----------------------------------------------------------- > > (Updated July 2, 2015, 2:05 a.m.) > > > Review request for mesos, Anand Mazumdar, Benjamin Hindman, Ben Mahler, Marco > Massenzio, and Vinod Kone. > > > Bugs: MESOS-2860 > https://issues.apache.org/jira/browse/MESOS-2860 > > > Repository: mesos-incubating > > > Description > ------- > > Adding a call route with HTTP request header validations > > > Diffs > ----- > > src/Makefile.am a064d17 > src/master/http.cpp 2be613b > src/master/http_constants.hpp PRE-CREATION > src/master/http_constants.cpp PRE-CREATION > src/master/master.hpp af83d3e > src/master/master.cpp a7486d8 > src/master/validation.hpp 469d6f5 > src/master/validation.cpp 9d128aa > src/tests/call_tests.cpp PRE-CREATION > src/tests/mesos.hpp 9157ac0 > > Diff: https://reviews.apache.org/r/36037/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Isabel Jimenez > >
