----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36113/#review90161 -----------------------------------------------------------
src/linux/perf.cpp (line 468) <https://reviews.apache.org/r/36113/#comment143149> Could you replace the function pointer with a lambda? src/linux/perf.cpp (line 488) <https://reviews.apache.org/r/36113/#comment143150> Seems odd to return cgroup="" when there is no cgroup rather than just not add a cgroup entry to the map at all. - Paul Brett On July 1, 2015, 10:44 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36113/ > ----------------------------------------------------------- > > (Updated July 1, 2015, 10:44 p.m.) > > > Review request for mesos, Ian Downes, Paul Brett, and Cong Wang. > > > Bugs: mesos-2834 > https://issues.apache.org/jira/browse/mesos-2834 > > > Repository: mesos > > > Description > ------- > > perf: refactored parse to allow determining an output parsing function based > on the runtime version. > > > Diffs > ----- > > src/linux/perf.cpp 697b75e846a43d4f106ad8f39a18882836d7dc02 > > Diff: https://reviews.apache.org/r/36113/diff/ > > > Testing > ------- > > > Thanks, > > Chi Zhang > >
