> On June 25, 2015, 10:17 p.m., Marco Massenzio wrote: > > src/tests/scheduler_tests.cpp, line 736 > > <https://reviews.apache.org/r/35856/diff/1/?file=991718#file991718line736> > > > > Same comment as the other review :) > > > > Great test, worth maybe factoring some of the common functionality in a > > helper class?
not sure, what the best abstractions are yet. so i will it as is as it is easy to understand even if it's verbose. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35856/#review89436 ----------------------------------------------------------- On July 1, 2015, 5:25 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35856/ > ----------------------------------------------------------- > > (Updated July 1, 2015, 5:25 a.m.) > > > Review request for mesos, Anand Mazumdar, Ben Mahler, Isabel Jimenez, and > Marco Massenzio. > > > Bugs: MESOS-2551 > https://issues.apache.org/jira/browse/MESOS-2551 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064 > src/master/master.cpp 34ce744f84465ecc9aeecd5fdc3d06047a4b7d92 > src/scheduler/scheduler.cpp f360e4d062488986b14e3d48d140996e8ed9e7d6 > src/tests/scheduler_tests.cpp cbe6c91a1b4f864ceb11cf062da0ada6c9666f9f > > Diff: https://reviews.apache.org/r/35856/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
