----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36003/#review89833 -----------------------------------------------------------
Great job! Some minor suggestions/rewordings, but I'd say it's nearly shippable. docs/mesos-ssl.md (line 8) <https://reviews.apache.org/r/36003/#comment142655> "fetching"? How about "When building Mesos from source," s/0.23/0.23.0/ docs/mesos-ssl.md (line 15) <https://reviews.apache.org/r/36003/#comment142659> `Framework` or `Framework Scheduler/Executor`? docs/mesos-ssl.md (line 21) <https://reviews.apache.org/r/36003/#comment142663> If this is enabled __on the accepting side__, then the accepting side will downgrade... What is the default value? (for this and other variables?) docs/mesos-ssl.md (line 30) <https://reviews.apache.org/r/36003/#comment142665> s/This is overridden...required./When `SSL_REQUIRE_CERT` is true, `SSL_VERIFY_CERT` is overridden and all certificates will be verified _and_ required./ docs/mesos-ssl.md (line 33) <https://reviews.apache.org/r/36003/#comment142667> s/grabbing/hitting/ docs/mesos-ssl.md (line 36) <https://reviews.apache.org/r/36003/#comment142668> s/,// s/admins/administrator/ s/for why/to learn why/ docs/mesos-ssl.md (line 42) <https://reviews.apache.org/r/36003/#comment142669> s/Thefile/The file/ docs/mesos-ssl.md (line 45) <https://reviews.apache.org/r/36003/#comment142670> s/`:` separated/`:`-separated/ docs/mesos-ssl.md (lines 58 - 59) <https://reviews.apache.org/r/36003/#comment142671> Can you list RHEL/Ubuntu instructions as well? (For OpenSSL as well) docs/mesos-ssl.md (line 64) <https://reviews.apache.org/r/36003/#comment142672> <code> s/'openssl`/`openssl`/ </code> docs/mesos-ssl.md (line 83) <https://reviews.apache.org/r/36003/#comment142673> s/in-secure/insecure/ docs/mesos-ssl.md (line 85) <https://reviews.apache.org/r/36003/#comment142674> s/Webui/WebUI/ docs/mesos-ssl.md (line 86) <https://reviews.apache.org/r/36003/#comment142675> s/SSL enabled/SSL-enabled/ s/or not// - Adam B On June 29, 2015, 2:50 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36003/ > ----------------------------------------------------------- > > (Updated June 29, 2015, 2:50 p.m.) > > > Review request for mesos, Adam B and Benjamin Hindman. > > > Bugs: MESOS-2942 > https://issues.apache.org/jira/browse/MESOS-2942 > > > Repository: mesos > > > Description > ------- > > [Here](https://gist.github.com/jmlvanre/82f30d9ea1ea4d815736) is a Github > rendered version > > > Diffs > ----- > > docs/mesos-ssl.md PRE-CREATION > > Diff: https://reviews.apache.org/r/36003/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
