----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35981/#review89773 -----------------------------------------------------------
Ship it! LGTM overall! Thanks a lot, mpark! docs/persistent-volume.md (lines 23 - 24) <https://reviews.apache.org/r/35981/#comment142569> We don't store 'principal' in DiskInfo yet. Maybe add a "coming soon" somewhere as well? docs/persistent-volume.md (line 29) <https://reviews.apache.org/r/35981/#comment142571> via the `acceptOffers` API (or the `ACCEPT` call in the new API). docs/persistent-volume.md (lines 63 - 64) <https://reviews.apache.org/r/35981/#comment142574> by sending the following `Offer::Operation` message via the `acceptOffers` API. docs/persistent-volume.md (lines 67 - 69) <https://reviews.apache.org/r/35981/#comment142576> The numbering is not correct:) docs/persistent-volume.md (line 68) <https://reviews.apache.org/r/35981/#comment142577> We only support non nested relative container path right now. docs/persistent-volume.md (line 69) <https://reviews.apache.org/r/35981/#comment142579> Please call out that 'RO' is not supported yet. docs/persistent-volume.md (line 168) <https://reviews.apache.org/r/35981/#comment142580> sending the `Offer::Operation` message via the `acceptOffers` API. - Jie Yu On June 28, 2015, 3:35 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35981/ > ----------------------------------------------------------- > > (Updated June 28, 2015, 3:35 a.m.) > > > Review request for mesos, Adam B, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-2405 > https://issues.apache.org/jira/browse/MESOS-2405 > > > Repository: mesos > > > Description > ------- > > The Github rendered version is available [here]( > https://github.com/mesosphere/mesos/blob/user-docs/docs/persistent-volume.md) > > > Diffs > ----- > > docs/persistent-volume.md PRE-CREATION > > Diff: https://reviews.apache.org/r/35981/diff/ > > > Testing > ------- > > Documentation. > > > Thanks, > > Michael Park > >
