----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35910/#review89573 -----------------------------------------------------------
src/exec/exec.cpp (line 492) <https://reviews.apache.org/r/35910/#comment142199> You can leave it as const. See the next comment. src/exec/exec.cpp (lines 496 - 497) <https://reviews.apache.org/r/35910/#comment142197> s/create/overwrite/ s/pure clients/HTTP API/ Can you move this down to #514 where we also overwrite slave id? src/exec/exec.cpp (line 498) <https://reviews.apache.org/r/35910/#comment142198> what do you mean by "needs to be validated"? can you elaborate? - Vinod Kone On June 26, 2015, 9:11 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35910/ > ----------------------------------------------------------- > > (Updated June 26, 2015, 9:11 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Now that `TaskStatus` includes a 'uuid', the executor driver should set it > the same as the `StatusUpdate` 'uuid'. > > For pure clients, we'll have to use and validate the 'uuid' coming from the > executor. I've added a TODO for this in a subsequent patch. > > > Diffs > ----- > > src/exec/exec.cpp 930dda91068dc6ccbab848b5723ce1568f042779 > > Diff: https://reviews.apache.org/r/35910/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
