----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/#review89222 -----------------------------------------------------------
+1 on Adam's comments. src/master/master.hpp (lines 630 - 651) <https://reviews.apache.org/r/35711/#comment141817> Can you move this function to src/master/validation.hpp|cpp ``` namespace role { Option<Error> validate(const std::string& role); } ``` src/master/master.hpp (lines 638 - 639) <https://reviews.apache.org/r/35711/#comment141820> Add a space after 'foreach' - Jie Yu On June 21, 2015, 2:21 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35711/ > ----------------------------------------------------------- > > (Updated June 21, 2015, 2:21 p.m.) > > > Review request for mesos, Adam B and Jie Yu. > > > Bugs: MESOS-2210 > https://issues.apache.org/jira/browse/MESOS-2210 > > > Repository: mesos > > > Description > ------- > > Disallow special characters in role name. > > > Diffs > ----- > > src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064 > src/master/master.cpp 0135c155181546d3cb43e9e05bb874af846d928d > > Diff: https://reviews.apache.org/r/35711/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
