----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35815/#review89124 -----------------------------------------------------------
src/tests/master_contender_detector_tests.cpp (line 861) <https://reviews.apache.org/r/35815/#comment141723> We are leaking here ? Using Group group(...); should suffice here. src/tests/master_contender_detector_tests.cpp (line 865) <https://reviews.apache.org/r/35815/#comment141724> Leaking here too. This can be wrapped in Owned<> - Anand Mazumdar On June 24, 2015, 1:15 a.m., Marco Massenzio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35815/ > ----------------------------------------------------------- > > (Updated June 24, 2015, 1:15 a.m.) > > > Review request for mesos, Niklas Nielsen and Vinod Kone. > > > Bugs: MESOS-2898 > https://issues.apache.org/jira/browse/MESOS-2898 > > > Repository: mesos > > > Description > ------- > > As of Mesos 0.24, we will support JSON format > for the MasterInfo information written out to > ZooKeeper for the Leader election process. > > This tests that the JSON can be correctly parsed > and the correct MasterInfo information retrieved. > > Jira: MESOS-2898 > > > Diffs > ----- > > src/tests/master_contender_detector_tests.cpp > 1b30eeb51520da7a5834768ac88a88a8a84fd976 > > Diff: https://reviews.apache.org/r/35815/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Marco Massenzio > >
