----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34721/#review88128 -----------------------------------------------------------
src/tests/mesos.hpp (line 205) <https://reviews.apache.org/r/34721/#comment140534> Can you instead add a overload for qosController only (similar to what we did for resourceEstimator above)? src/tests/oversubscription_tests.cpp (line 789) <https://reviews.apache.org/r/34721/#comment140535> s/KillExecutorQoSCorrection/QoSCorrectionKill/ src/tests/oversubscription_tests.cpp (line 799) <https://reviews.apache.org/r/34721/#comment140536> This should be InvokeWithoutArgs Could you please fix all instances in this file? src/tests/oversubscription_tests.cpp (line 803) <https://reviews.apache.org/r/34721/#comment140537> No need to save this temp variable. src/tests/oversubscription_tests.cpp (lines 827 - 834) <https://reviews.apache.org/r/34721/#comment140538> can you use 'createTask' to construct the task? See examples in this file. src/tests/oversubscription_tests.cpp (line 842) <https://reviews.apache.org/r/34721/#comment140539> You may wanna add ``` .WillRepeatedly(Return()); // Ignore subsequent updates. ``` after the second `.WillOnce` src/tests/oversubscription_tests.cpp (line 850) <https://reviews.apache.org/r/34721/#comment140540> Please kill mesos::slave prefix src/tests/oversubscription_tests.cpp (lines 859 - 861) <https://reviews.apache.org/r/34721/#comment140541> Use initialization list please:) - Jie Yu On June 16, 2015, 8:43 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34721/ > ----------------------------------------------------------- > > (Updated June 16, 2015, 8:43 p.m.) > > > Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and > Vinod Kone. > > > Bugs: MESOS-2653 > https://issues.apache.org/jira/browse/MESOS-2653 > > > Repository: mesos > > > Description > ------- > > See summary > > > Diffs > ----- > > src/tests/mesos.hpp ecdf9109d2e46e8730754eeeb4978863679d56e7 > src/tests/mesos.cpp 509f9f205fdb1fa094e313b6f0da53000ffecbb3 > src/tests/oversubscription_tests.cpp > 3481ad2eef43c3860642970b4c96494997de8552 > > Diff: https://reviews.apache.org/r/34721/diff/ > > > Testing > ------- > > make check (with new qos test) > > > Thanks, > > Niklas Nielsen > >
