----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34632/#review86501 -----------------------------------------------------------
LGTM overall. Just one place (regarding the time when we start to receive/act on corrections) needs more thoughts. src/slave/main.cpp <https://reviews.apache.org/r/34632/#comment138545> Kill this extra line. src/slave/main.cpp <https://reviews.apache.org/r/34632/#comment138546> Kill this extra line. src/slave/slave.hpp <https://reviews.apache.org/r/34632/#comment138547> include order src/slave/slave.cpp <https://reviews.apache.org/r/34632/#comment138548> Reorder src/slave/slave.cpp <https://reviews.apache.org/r/34632/#comment138555> I would kill this line to be consistent with resource estimator above. (or add one line for resource estimator). src/slave/slave.cpp <https://reviews.apache.org/r/34632/#comment138560> Can you explain why you want to start receiving/acting on corrections even before the slave is recovered? How do you kill a container if the slave is not recovered? src/slave/slave.cpp <https://reviews.apache.org/r/34632/#comment138554> Add one more line here. src/tests/mesos.cpp <https://reviews.apache.org/r/34632/#comment138561> const Option<...>... - Jie Yu On June 3, 2015, 4:28 a.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34632/ > ----------------------------------------------------------- > > (Updated June 3, 2015, 4:28 a.m.) > > > Review request for mesos, Bartek Plotka, Jie Yu, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Wired up QoS Controller in slave and necessary test code for the new slave > constructor argument. > > > Diffs > ----- > > src/local/local.cpp 84f73e21e66e7a654b6b09f6a57a70a1ccc34b40 > src/slave/flags.hpp 15dd8387df1344807b54e911a8094a89f4629cbd > src/slave/main.cpp e3a45f4dfa0c8cc5d28d795f42bdc8cd14b7b10d > src/slave/slave.hpp 245ea062a56461d96ee3055be1c93ec508d1bec7 > src/slave/slave.cpp 271cb03770cd08406054dfce35d0821475e49b05 > src/tests/cluster.hpp 7370c77de68d3a13340a69f6e794d97306d4bbb6 > src/tests/mesos.hpp aeeed61ea987963345a8b5c6e09d14e51098bb2e > src/tests/mesos.cpp d3a8bb70478993883f34804c8e2d7559d16c3538 > > Diff: https://reviews.apache.org/r/34632/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
