----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34631/#review86499 -----------------------------------------------------------
Ship it! include/mesos/slave/qos_controller.hpp <https://reviews.apache.org/r/34631/#comment138542> Can you add a wrapper header mesos/slave/oversubscription.hpp similar to what we do for things like fetcher? src/slave/qos_controller.cpp <https://reviews.apache.org/r/34631/#comment138543> Not sure about the style here. I thought we don't add leading spaces here (similar to template functions). - Jie Yu On June 3, 2015, 4:26 a.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34631/ > ----------------------------------------------------------- > > (Updated June 3, 2015, 4:26 a.m.) > > > Review request for mesos, Bartek Plotka, Jie Yu, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Added QoS Controller class and NOOP controller implementation > > > Diffs > ----- > > include/mesos/slave/qos_controller.hpp PRE-CREATION > src/Makefile.am f045b89e8590c4775b21980bedff14cc27d31bfb > src/slave/qos_controller.hpp PRE-CREATION > src/slave/qos_controller.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/34631/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
