> On May 26, 2015, 10:56 p.m., Chi Zhang wrote: > > src/linux/routing/queueing/fq_codel.cpp, line 80 > > <https://reviews.apache.org/r/34426/diff/7/?file=969377#file969377line80> > > > > would egress::ROOT be more consistent?
Yes, but it would require adding a namespace to hold a single value. - Paul ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34426/#review85274 ----------------------------------------------------------- On May 31, 2015, 7:53 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34426/ > ----------------------------------------------------------- > > (Updated May 31, 2015, 7:53 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. > > > Bugs: MESOS-2665 > https://issues.apache.org/jira/browse/MESOS-2665 > > > Repository: mesos > > > Description > ------- > > Report the network statistics from libnl > > > Diffs > ----- > > src/Makefile.am 9d1f0d5de2e7647a6677d86f5032ae1b79f1b241 > src/linux/routing/queueing/fq_codel.hpp > 7de1e31d4c43ac9cbffab1e472ea51140719f900 > src/linux/routing/queueing/fq_codel.cpp > 64b5c73e8cfa672141ddb663e879c58b4babfdbc > src/linux/routing/queueing/ingress.hpp > 84506fecd01522471a7998176c28bea8f1367aed > src/linux/routing/queueing/ingress.cpp > ae0c38d2215e7fabcc1060e7385484bd455e1699 > src/linux/routing/queueing/internal.hpp > d43a9fd405af2e59dc57cfc7ba9b5e77cb9f6b70 > src/linux/routing/queueing/statistics.hpp PRE-CREATION > src/linux/routing/queueing/statistics.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/34426/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Paul Brett > >
