----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30643/ -----------------------------------------------------------
(Updated May 26, 2015, 3:49 p.m.) Review request for mesos, Timothy Chen and Vinod Kone. Changes ------- @tnachen could you take another look at this when you get some time, I'd like to commit it soon. Repository: mesos Description ------- Provided executor will be used to run the task rather than deferring to the slave to determine an executor to use (currently the local included command executor). This is helpful for testing containers with filesystem isolation as you can fetch an executor into the work directory rather than using the command executor on the host filesystem. You can, of course, still use the command executor, but it will be copied/fetched. +tnachen - can you please verify I've preserved the override functionality in the command executor? Is that still required? Diffs (updated) ----- src/cli/execute.cpp dbd19e67f56a150f54180ad13e6402842eb68e17 src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 src/launcher/executor.cpp de6f1b104a765a8e53934154e78872b03695b24c Diff: https://reviews.apache.org/r/30643/diff/ Testing ------- make check manually used 'mesos execute' and specified command executor, both directly as the value and fetching from file:///. Tested enviroment variables too. Thanks, Ian Downes
