> On Aug. 22, 2013, 11:38 p.m., Ben Mahler wrote: > > I'm ok with adding these kinds of things to .gitignore. > > Marco Massenzio wrote: > I'm confused here - see comments to https://reviews.apache.org/r/33448 > > Also, what's the relationship with .gitignore-template? are we dropping > it? > > To be clear, I fully support these changes (I was the one proposing them > :) but would like to understand what's changed and how do we manage > .gitignore and .gitignore-template.
> I'm confused here - see comments to https://reviews.apache.org/r/33448 Looks like this patch is from 2013, whereas the discussion in BenM's [link](http://markmail.org/thread/7mu6lzkv3b6hngww) is from 2014. > Also, what's the relationship with .gitignore-template? are we dropping it? I think the `.gitignore-template` will stay. Although we might consider moving it to `support/gitignore`, since we now have other similar templates: `support/reviewboardrc` and `support/clang-format` which get symlinked as `.reviewboardrc` and `.clang-format` respectively. > how do we manage .gitignore and .gitignore-template. By default `bootstrap` symlinks `.gitignore-template` to `.gitignore` if there doesn't already exist a `.gitignore`. But it's likely that most people would diverge from the template by copying `.gitignore-template` to `.gitignore` instead and augmenting it with whatever else they want to further ignore (e.g. their IDE-specific settings). - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13709/#review25439 ----------------------------------------------------------- On Aug. 22, 2013, 7:06 a.m., Kevin Lyda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13709/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2013, 7:06 a.m.) > > > Review request for mesos. > > > Bugs: MESOS-654 > https://issues.apache.org/jira/browse/MESOS-654 > > > Repository: mesos > > > Description > ------- > > Fixed a few typos, added a .gitignore, removed a generated file. > > > Diffs > ----- > > .gitignore PRE-CREATION > 3rdparty/libprocess/install-sh 6781b98 > README e94531d > src/common/values.cpp ce26119 > src/linux/cgroups.cpp b97a89c > src/log/coordinator.cpp 6e6466f > src/log/log.cpp aea06e7 > src/master/master.cpp d53b8bb > src/slave/slave.cpp 92a0a7e > src/tests/allocator_tests.cpp c57da6e > src/tests/resources_tests.cpp 964a1b6 > src/tests/status_update_manager_tests.cpp cf420e4 > > Diff: https://reviews.apache.org/r/13709/diff/ > > > Testing > ------- > > git clean -fxd > ./bootstrap > cd build > ../configure > make > make check > > All these work as they did before. git status is now clean when the tree is > built (unless there have been code changes made). git diff only shows code > changes, not stuff from generated files. > > > Thanks, > > Kevin Lyda > >
