Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20718 )

Change subject: IMPALA-12570: Add longer strings to tables containing 
collections
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

Thanks for making these change, LGTM!

http://gerrit.cloudera.org:8080/#/c/20718/2/testdata/datasets/functional/functional_schema_template.sql
File testdata/datasets/functional/functional_schema_template.sql:

http://gerrit.cloudera.org:8080/#/c/20718/2/testdata/datasets/functional/functional_schema_template.sql@3894
PS2, Line 3894: a
It was clever to use the prefixes of old data. It makes it much easier to 
validate the these tests!



--
To view, visit http://gerrit.cloudera.org:8080/20718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief770d6bc9258fce159a733d5afa34fe594b96f8
Gerrit-Change-Number: 20718
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Tue, 21 Nov 2023 13:46:56 +0000
Gerrit-HasComments: Yes

Reply via email to