Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20682 )

Change subject: IMPALA-9086: Show Hive configurations in /hadoop-varz page
......................................................................


Patch Set 2:

(12 comments)

http://gerrit.cloudera.org:8080/#/c/20682/2/be/src/catalog/catalog-server.h
File be/src/catalog/catalog-server.h:

http://gerrit.cloudera.org:8080/#/c/20682/2/be/src/catalog/catalog-server.h@329
PS2, Line 329:
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/20682/2/be/src/catalog/catalog.h
File be/src/catalog/catalog.h:

http://gerrit.cloudera.org:8080/#/c/20682/2/be/src/catalog/catalog.h@143
PS2, Line 143:
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/20682/2/fe/src/main/java/org/apache/impala/service/JniCatalog.java
File fe/src/main/java/org/apache/impala/service/JniCatalog.java:

http://gerrit.cloudera.org:8080/#/c/20682/2/fe/src/main/java/org/apache/impala/service/JniCatalog.java@124
PS2, Line 124:   }
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/20682/2/fe/src/main/java/org/apache/impala/service/JniCatalog.java@125
PS2, Line 125:
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/20682/2/fe/src/main/java/org/apache/impala/service/JniCatalog.java@126
PS2, Line 126:   // IMPALA-9086: required for getAllHadoopConfigs static page: 
/hadoop-varz
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/20682/2/fe/src/main/java/org/apache/impala/service/JniCatalog.java@550
PS2, Line 550:    *
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/20682/2/fe/src/main/java/org/apache/impala/service/JniCatalog.java@551
PS2, Line 551:    * IMPALA-9086 : /hadoop-varz http request has been to catalog 
webui simillar to impalad webui
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/20682/2/fe/src/main/java/org/apache/impala/service/JniFrontend.java
File fe/src/main/java/org/apache/impala/service/JniFrontend.java:

http://gerrit.cloudera.org:8080/#/c/20682/2/fe/src/main/java/org/apache/impala/service/JniFrontend.java@637
PS2, Line 637:    *
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/20682/2/fe/src/main/java/org/apache/impala/service/JniFrontend.java@638
PS2, Line 638:    * IMPALA-9086 : /hadoop-varz http request has been updated to 
include Hive configurations
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/20682/2/fe/src/main/java/org/apache/impala/service/JniFrontend.java@638
PS2, Line 638:    * IMPALA-9086 : /hadoop-varz http request has been updated to 
include Hive configurations
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/20682/2/fe/src/main/java/org/apache/impala/service/JniFrontend.java@639
PS2, Line 639:    * from : org.apache.hadoop.conf.Configuration
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/20682/2/fe/src/main/java/org/apache/impala/service/JniFrontend.java@640
PS2, Line 640:    * to   : org.apache.hadoop.hive.conf.HiveConf (inherrits 
Configuration)
line has trailing whitespace



--
To view, visit http://gerrit.cloudera.org:8080/20682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5af0eb68e71afeed64660d4d40584208ea503217
Gerrit-Change-Number: 20682
Gerrit-PatchSet: 2
Gerrit-Owner: Saurabh Katiyal <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Thu, 09 Nov 2023 18:45:59 +0000
Gerrit-HasComments: Yes

Reply via email to