Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20676 )
Change subject: IMPALA-12333: SHOW CREATE TABLE outputs some unnecessary table properties ...................................................................... Patch Set 1: (15 comments) http://gerrit.cloudera.org:8080/#/c/20676/1/tests/metadata/test_show_create_table.py File tests/metadata/test_show_create_table.py: http://gerrit.cloudera.org:8080/#/c/20676/1/tests/metadata/test_show_create_table.py@30 PS1, Line 30: def properties_map_regex(name): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/20676/1/tests/metadata/test_show_create_table.py@31 PS1, Line 31: \ flake8: W605 invalid escape sequence '\(' http://gerrit.cloudera.org:8080/#/c/20676/1/tests/metadata/test_show_create_table.py@31 PS1, Line 31: \ flake8: W605 invalid escape sequence '\)' http://gerrit.cloudera.org:8080/#/c/20676/1/tests/metadata/test_show_create_table.py@33 PS1, Line 33: def get_properties_map(sql, properties_map_name, exclusions = None): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/20676/1/tests/metadata/test_show_create_table.py@33 PS1, Line 33: flake8: E251 unexpected spaces around keyword / parameter equals http://gerrit.cloudera.org:8080/#/c/20676/1/tests/metadata/test_show_create_table.py@33 PS1, Line 33: flake8: E251 unexpected spaces around keyword / parameter equals http://gerrit.cloudera.org:8080/#/c/20676/1/tests/metadata/test_show_create_table.py@42 PS1, Line 42: \ flake8: W605 invalid escape sequence '\s' http://gerrit.cloudera.org:8080/#/c/20676/1/tests/metadata/test_show_create_table.py@42 PS1, Line 42: \ flake8: W605 invalid escape sequence '\s' http://gerrit.cloudera.org:8080/#/c/20676/1/tests/metadata/test_show_create_table.py@310 PS1, Line 310: def get_tbl_properties_from_describe_formatted(lines): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/20676/1/tests/metadata/test_show_create_table.py@324 PS1, Line 324: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/20676/1/tests/metadata/test_show_create_table.py@324 PS1, Line 324: flake8: E202 whitespace before ']' http://gerrit.cloudera.org:8080/#/c/20676/1/tests/metadata/test_show_create_table.py@329 PS1, Line 329: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/20676/1/tests/metadata/test_show_create_table.py@335 PS1, Line 335: class TestShowCreateTableIcebergProperties(ImpalaTestSuite): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/20676/1/tests/metadata/test_show_create_table.py@351 PS1, Line 351: a flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/20676/1/tests/metadata/test_show_create_table.py@373 PS1, Line 373: \ flake8: E502 the backslash is redundant between brackets -- To view, visit http://gerrit.cloudera.org:8080/20676 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id6f2cb9194f685a583b0d550532eb2454f119666 Gerrit-Change-Number: 20676 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 08 Nov 2023 10:10:07 +0000 Gerrit-HasComments: Yes
