Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20612 )
Change subject: IMPALA-3825: Delegate runtime filter aggregation to some executors ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/20612/3/be/src/runtime/runtime-filter-bank.cc File be/src/runtime/runtime-filter-bank.cc: http://gerrit.cloudera.org:8080/#/c/20612/3/be/src/runtime/runtime-filter-bank.cc@690 PS3, Line 690: wait_time_ms = query_state_->query_options().runtime_filter_wait_time_ms; > Still seems like that should use an atomic then. Changed to hold lock before checking cancelled_. This should be safe, because cancelled_ can only change if all locks are hold. http://gerrit.cloudera.org:8080/#/c/20612/5/tests/common/test_dimensions.py File tests/common/test_dimensions.py: http://gerrit.cloudera.org:8080/#/c/20612/5/tests/common/test_dimensions.py@261 PS5, Line 261: combinations = product(*(exec_option_dimensions[name] for name in keys)) : exec_option_dimension_values = [dict(zip(keys, prod)) for prod in combinations] : > This is probably the reason why extra exec options are always declared with Added ImpalaTestMatrix.add_exec_option_dimension() in patch set 5 for easier extra exec option declaration without losing pairwise combination. -- To view, visit http://gerrit.cloudera.org:8080/20612 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11d38ed0f223d6e5b32a19ebe725af7738ee4ab0 Gerrit-Change-Number: 20612 Gerrit-PatchSet: 6 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 26 Oct 2023 01:22:24 +0000 Gerrit-HasComments: Yes
