Michael Smith has posted comments on this change. (
http://gerrit.cloudera.org:8080/20494 )
Change subject: IMPALA-12390 (part 4): Enable unnecessary-value-param
......................................................................
Patch Set 2:
Negligible (possibly positive) impact on performance
+----------+-----------------------+---------+------------+------------+----------------+
| Workload | File Format | Avg (s) | Delta(Avg) | GeoMean(s) |
Delta(GeoMean) |
+----------+-----------------------+---------+------------+------------+----------------+
| TPCH(42) | parquet / none / none | 3.56 | -0.16% | 2.35 | -0.27%
|
+----------+-----------------------+---------+------------+------------+----------------+
+----------+--------+-------------+------------+-----------+----------------+-------+----------------+---------+-------+
| Query | Avg(s) | Base Avg(s) | Delta(Avg) | StdDev(%) | Base StdDev(%) |
Iters | Median Diff(%) | MW Zval | Tval |
+----------+--------+-------------+------------+-----------+----------------+-------+----------------+---------+-------+
| TPCH-Q1 | 4.74 | 4.64 | +2.08% | 1.58% | 1.40% |
50 | +2.12% | 6.44 | 6.88 |
| TPCH-Q13 | 5.96 | 5.89 | +1.17% | 0.57% | 1.08% |
50 | +1.63% | 6.30 | 6.75 |
| TPCH-Q6 | 0.69 | 0.69 | +1.11% | 3.58% | 3.59% |
50 | +0.23% | 1.72 | 1.54 |
| TPCH-Q20 | 1.56 | 1.55 | +0.80% | 2.30% | 2.12% |
50 | +0.06% | 1.10 | 1.80 |
| TPCH-Q14 | 1.65 | 1.64 | +0.30% | 2.37% | 1.89% |
50 | +0.07% | 1.60 | 0.71 |
| TPCH-Q15 | 2.28 | 2.28 | +0.10% | 2.05% | 1.48% |
50 | +0.02% | 0.17 | 0.28 |
| TPCH-Q21 | 17.83 | 17.81 | +0.08% | 0.57% | 0.43% |
50 | +0.01% | 0.55 | 0.79 |
| TPCH-Q8 | 2.49 | 2.49 | +0.04% | 2.18% | 2.08% |
50 | -0.00% | -0.00 | 0.09 |
| TPCH-Q9 | 9.75 | 9.77 | -0.14% | 0.82% | 0.87% |
50 | -0.09% | -1.32 | -0.82 |
| TPCH-Q19 | 1.24 | 1.24 | -0.23% | 1.24% | 1.50% |
50 | -0.03% | -0.79 | -0.82 |
| TPCH-Q3 | 3.46 | 3.47 | -0.35% | 1.38% | 1.20% |
50 | -0.03% | -1.27 | -1.35 |
| TPCH-Q11 | 0.54 | 0.55 | -0.33% | 4.47% | 4.38% |
50 | -0.16% | -1.32 | -0.38 |
| TPCH-Q5 | 1.95 | 1.96 | -0.58% | 1.44% | 1.69% |
50 | -0.06% | -1.47 | -1.85 |
| TPCH-Q12 | 1.48 | 1.49 | -0.67% | 2.11% | 2.14% |
50 | -0.12% | -1.49 | -1.59 |
| TPCH-Q4 | 1.89 | 1.91 | -0.81% | 1.57% | 1.72% |
50 | -0.05% | -2.35 | -2.49 |
| TPCH-Q2 | 0.66 | 0.67 | -0.76% | 3.89% | 4.17% |
50 | -0.16% | -1.02 | -0.94 |
| TPCH-Q16 | 1.37 | 1.39 | -1.03% | 2.09% | 1.18% |
50 | -0.04% | -2.37 | -3.05 |
| TPCH-Q17 | 1.86 | 1.89 | -1.47% | 4.69% | 6.37% |
50 | -0.27% | -0.96 | -1.32 |
| TPCH-Q22 | 1.75 | 1.79 | -1.96% | 1.72% | 4.41% |
50 | -0.19% | -3.61 | -2.94 |
| TPCH-Q10 | 3.03 | 3.07 | -1.04% | 1.85% | 1.94% |
50 | -1.42% | -2.21 | -2.76 |
| TPCH-Q7 | 2.82 | 2.85 | -1.07% | 1.78% | 2.04% |
50 | -1.54% | -2.53 | -2.81 |
| TPCH-Q18 | 9.36 | 9.48 | -1.29% | 1.28% | 1.17% |
50 | -1.51% | -5.01 | -5.30 |
+----------+--------+-------------+------------+-----------+----------------+-------+----------------+---------+-------+
--
To view, visit http://gerrit.cloudera.org:8080/20494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8aa5d98596d82f615a0a728e0235e7dd9d8b5003
Gerrit-Change-Number: 20494
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Comment-Date: Wed, 20 Sep 2023 17:33:04 +0000
Gerrit-HasComments: No
