Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19954 )
Change subject: IMPALA-12449: remove dependence on sse2neon ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/19954/8/be/src/util/bit-util.h File be/src/util/bit-util.h: http://gerrit.cloudera.org:8080/#/c/19954/8/be/src/util/bit-util.h@153 PS8, Line 153: return POPCNT_popcnt_u64(x); > I'm confused why this didn't work. It should be similar to the option below The compilation fails during IR compilation with Clang, which sets IR_COMPILE=true. sse-util.h currently has POPCNT_popcnt_u64 under the #ifndef IR_COMPILE section. We don't have a definition for it under the final section (which handles IR_COMPILE=true without SSE). -- To view, visit http://gerrit.cloudera.org:8080/19954 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3c78c877ef530fa9f35d36da523ad67ab34e5e7 Gerrit-Change-Number: 19954 Gerrit-PatchSet: 8 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Mon, 18 Sep 2023 17:33:09 +0000 Gerrit-HasComments: Yes
