Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24275 )
Change subject: IMPALA-14949: Fix Catalogd Startup Deadlock ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/24275/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/24275/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2611 PS1, Line 2611: triggeredInitialReset_ > The behavior matches syncDdl, which semantically makes sense for startup. H In a failover situation today, the deadlock won't happen even if CatalogServiceCatalog.rebuildDbCache releases the versionLock_ write lock because triggeredInitialReset_ will be `true` and thus other threads will not sleep in CatalogServiceCatalog.waitInitialResetCompletion. I also considered making the reset that happens after a Catalogd failover not yield versionLock_ write lock, but that is a behavior change from what happens today. Maybe it is a change we want to make though? -- To view, visit http://gerrit.cloudera.org:8080/24275 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe71980d6fed5a95b00bc7b710c781f909545404 Gerrit-Change-Number: 24275 Gerrit-PatchSet: 1 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 05 May 2026 23:45:55 +0000 Gerrit-HasComments: Yes
