Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24276 )

Change subject: IMPALA-14847 (addendum): Add Iceberg's FilepathToHostsMapPB to 
large RPC logging
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/24276/1/be/src/runtime/coordinator-backend-state.cc
File be/src/runtime/coordinator-backend-state.cc:

http://gerrit.cloudera.org:8080/#/c/24276/1/be/src/runtime/coordinator-backend-state.cc@372
PS1, Line 372:         filepath_to_host_size += 4;
Would sizeof(val.first) be statically determined and more descriptive?


http://gerrit.cloudera.org:8080/#/c/24276/1/be/src/runtime/coordinator-backend-state.cc@390
PS1, Line 390:                    << " filepath to host map: "
Maybe only output it if filepath_to_host_size > 0?



--
To view, visit http://gerrit.cloudera.org:8080/24276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1411aeea9351a55ed618d205734c9cad519daf8c
Gerrit-Change-Number: 24276
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Tue, 05 May 2026 23:24:02 +0000
Gerrit-HasComments: Yes

Reply via email to