Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/24132 )
Change subject: IMPALA-14851: Codegen GroupingAggregator::CopyGroupingValues ...................................................................... Patch Set 6: (1 comment) The performance looks good, but the commit message doesn't mention testing, has this passed the ASAN and exhaustive tests to ensure memory safety? http://gerrit.cloudera.org:8080/#/c/24132/6/be/src/exec/grouping-aggregator-ir.cc File be/src/exec/grouping-aggregator-ir.cc: http://gerrit.cloudera.org:8080/#/c/24132/6/be/src/exec/grouping-aggregator-ir.cc@337 PS6, Line 337: void GroupingAggregator::CopyGroupingValues2(Tuple* intermediate_tuple, uint8_t* buffer, : int varlen_size) { : CopyGroupingValues(intermediate_tuple, buffer, varlen_size); : } It seems this never being used? -- To view, visit http://gerrit.cloudera.org:8080/24132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2c54a5745ba05a926795318d3b074fde6d0c00a Gerrit-Change-Number: 24132 Gerrit-PatchSet: 6 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 02 Apr 2026 04:52:04 +0000 Gerrit-HasComments: Yes
