Hello Quanlong Huang, Aman Sinha, Fang-Yu Rao, Jason Fehr, Joe McDonnell,
Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24078
to look at the new patch set (#2).
Change subject: IMPALA-14412: Calcite Planner: Need to handle exponent notation
correctly
......................................................................
IMPALA-14412: Calcite Planner: Need to handle exponent notation correctly
Calcite treats expressions like "1e32" as a double. This commit ensures that
the exponent expressions are parsed as decimal types.
test can be found in decimal-exprs.test
select avg(c) from
(select cast(1e32 as decimal(38,0)) - cast(1 as decimal(38,0)) as c) t;
This change is broken before the Calcite 1.41 upgrade, but can only be fixed
after the 1.41 upgrade has been committed.
Change-Id: Idea6d622e4f2720d323192f953867c4b82442627
---
M java/calcite-planner/src/main/codegen/templates/Parser.jj
A
java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaSqlNumericLiteral.java
M
java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeConverter.java
3 files changed, 47 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/78/24078/2
--
To view, visit http://gerrit.cloudera.org:8080/24078
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idea6d622e4f2720d323192f953867c4b82442627
Gerrit-Change-Number: 24078
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>