Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24079 )
Change subject: IMPALA-14820: Calcite Planner: Memory allocations are too high ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/24079/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/24079/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java@103 PS3, Line 103: // The "Sort" RelNode is used for limit and offset in addition to "order by" clauses. > nit: can we add a comment mentioning that Calcite uses the Sort RelNode for Done http://gerrit.cloudera.org:8080/#/c/24079/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java@108 PS3, Line 108: n fetch != n > Will this cast always succeed? This cast should always succeed. When the value is a numeric, it should be stored as a BigDecimal. RexLiteral is also used for strings, and in that case, it would not be a BigDecimal. But since this is a "fetch", it should only contain a numeric since it passed validation. -- To view, visit http://gerrit.cloudera.org:8080/24079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e84061b65f115ea65a9d2c2d40173843040ca0c Gerrit-Change-Number: 24079 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Fri, 27 Mar 2026 03:11:42 +0000 Gerrit-HasComments: Yes
