Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24123 )
Change subject: IMPALA-14796: Show effective runtime filter targets in profile ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/24123/2/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/24123/2/be/src/runtime/coordinator.cc@821 PS2, Line 821: } > Any concerns with stack overflows because of this recursion? Do you mean infinite recursion? Profile is a tree so I think it won't happen. Note that we use the same pattern at https://github.com/apache/impala/blob/20220fb9232b94d228383fe693a383d2c71a4733/be/src/service/query-state-record.cc#L355-L360 http://gerrit.cloudera.org:8080/#/c/24123/2/be/src/runtime/coordinator.cc@1481 PS2, Line 1481: ComputeEffectiveFilterTargets(); : { : lock_guard<shared_mutex> lock(filter_routing_table_->lock); : if (filter_routing_table_->num_filters() > 0) { : query_profile_->AddInfoString("Final filter table", FilterDebugString()); : > Nit: Surround this block with braces to ensure the compiler does not apply Good point! -- To view, visit http://gerrit.cloudera.org:8080/24123 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iccf4b87ac4579a70273f3306ec7b58850f06b17c Gerrit-Change-Number: 24123 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Thu, 26 Mar 2026 05:20:14 +0000 Gerrit-HasComments: Yes
