Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24043 )
Change subject: IMPALA-14432: Upgrade Calcite version to v1.41 ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/24043/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24043/3//COMMIT_MSG@37 PS3, Line 37: - fixed a regression for the 'like' operator in 1.41. The Calcite jira : associated with this is CALCITE-7287 which has been fixed in 1.42. The : code needed to work around this regression is in RexCallConverter and : can be removed when Calcite 1.42 is released. > Please open an IMPALA Jira for the Calcite 1.42 upgrade that notes this cod Ack. Filed IMPALA-14849 http://gerrit.cloudera.org:8080/#/c/24043/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24043/4//COMMIT_MSG@9 PS4, Line 9: The following changes were needed to upgrade Calcite to v1.41: > A large portion of the test changes involved differences in casting decimal Done http://gerrit.cloudera.org:8080/#/c/24043/4/testdata/workloads/functional-planner/queries/PlannerTest/calcite/limit-pushdown-analytic-calcite.test File testdata/workloads/functional-planner/queries/PlannerTest/calcite/limit-pushdown-analytic-calcite.test: http://gerrit.cloudera.org:8080/#/c/24043/4/testdata/workloads/functional-planner/queries/PlannerTest/calcite/limit-pushdown-analytic-calcite.test@614 PS4, Line 614: 1E+1 > I'm concerned about breaking profile analysis tools that expect decimal not Ok, I fixed this by changing some code in NumericLiteral, to use "toPlainString()" on the BigDecimal. Hopefully there will be no regressions on the jenkins run. I still need to do that. One other note: I was hoping that I would be able to remove the comparison to BigDecimal.ZERO in the "Numeric.getStringValue()" method since the comment indicates a similar problem. However, after I tried this, it was displaying "0" as 0.0, 0.00, or some other form of 0. It will probably cause too many regressions, so I kept that if/else logic. -- To view, visit http://gerrit.cloudera.org:8080/24043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fde6381c04958d69f1bee13864c11c7cd385d29 Gerrit-Change-Number: 24043 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 25 Mar 2026 17:24:31 +0000 Gerrit-HasComments: Yes
