Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/24124 )
Change subject: PROTOTYPE: IMPALA-11881: Improve WebUI JSON files to simplify automated analysis ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/24124/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24124/1//COMMIT_MSG@9 PS1, Line 9: certin nit. certain http://gerrit.cloudera.org:8080/#/c/24124/1/be/src/rpc/rpc-mgr.cc File be/src/rpc/rpc-mgr.cc: http://gerrit.cloudera.org:8080/#/c/24124/1/be/src/rpc/rpc-mgr.cc@301 PS1, Line 301: NetworkAddressPBToString This looks like passing a temporary string to AddMember(). Since AddMember() may not deep copy the string in this case, it might be safer to wrap it in a Value with the allocator http://gerrit.cloudera.org:8080/#/c/24124/1/be/src/rpc/rpc-mgr.cc@362 PS1, Line 362: network_plane Since AddMember() may not deep copy the network plane string in this case, it is better to deal with it like the remote_ip: Value remote_addr_str(conn.remote_ip().c_str(), document->GetAllocator()); per_conn_metrics_entry.AddMember( "remote_addr", remote_addr_str, document->GetAllocator()); -- To view, visit http://gerrit.cloudera.org:8080/24124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e70b6c8fbbe93096a5797cedb481ffb14de2a92 Gerrit-Change-Number: 24124 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 20 Mar 2026 17:49:54 +0000 Gerrit-HasComments: Yes
