Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24071 )
Change subject: IMPALA-14755:(part 1) Implement Puffin Blob reader and File writer ...................................................................... Patch Set 5: (4 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24071/5/be/src/exec/puffin/puffin-writer.cc File be/src/exec/puffin/puffin-writer.cc: http://gerrit.cloudera.org:8080/#/c/24071/5/be/src/exec/puffin/puffin-writer.cc@148 PS5, Line 148: XXH128_hash_t hash_result = XXH3_128bits(data_file_path.c_str(), data_file_path.size()); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/24071/5/common/fbs/IcebergObjects.fbs File common/fbs/IcebergObjects.fbs: PS5: This file is used in communication between impalad and catalogd/statestore. Please make sure impalads can still work with new/old versions of catalogd and statestore. Basically only new fields can be added and should be added at the end of a table definition. https://flatbuffers.dev/flatbuffers_guide_writing_schema.html http://gerrit.cloudera.org:8080/#/c/24071/5/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: http://gerrit.cloudera.org:8080/#/c/24071/5/common/thrift/CatalogObjects.thrift@679 PS5, Line 679: 10: optional map<THash128, Types.TIcebergDeletionVector> data_path_hash_to_dv Changing type of field 'data_path_hash_to_dv' from map<THash128,TIcebergDeletionVector> to map<THash128,Types.TIcebergDeletionVector> in TIcebergContentFileStore might break the compatibility between impalad and catalogd/statestore during upgrade http://gerrit.cloudera.org:8080/#/c/24071/5/common/thrift/DataSinks.thrift File common/thrift/DataSinks.thrift: http://gerrit.cloudera.org:8080/#/c/24071/5/common/thrift/DataSinks.thrift@124 PS5, Line 124: 2: optional map<CatalogObjects.THash128, Types.TIcebergDeletionVector> deletion_vectors; line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24071 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I068a071f9db907064ccec8568db5234863eb4587 Gerrit-Change-Number: 24071 Gerrit-PatchSet: 5 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 17 Mar 2026 15:42:11 +0000 Gerrit-HasComments: Yes
