Hello Aman Sinha, Fang-Yu Rao, Joe McDonnell, Michael Smith, Impala Public
Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24043
to look at the new patch set (#3).
Change subject: IMPALA-14432: Upgrade Calcite version to v1.41
......................................................................
IMPALA-14432: Upgrade Calcite version to v1.41
The following changes were needed to upgrade Calcite to v1.41:
- pom.xml file change
- Changed ImpalaConformance to derive from SqlAbstractConformance
which will automatically derive defaults for any new methods
in the class
- Handled a Calcite fix for coercing types across Union inputs.
Calcite can add a cast to a char literal to make it a different
size char literal, whereas Impala needs these literals to be
of type string.
- moved flatten code to only happen once and only happen within filter
creation (which is where the exception was thrown that it needed a
flattend RexNode).
- handled a problem where operator lists were greater than one and
the opname was not simple. This isn't used by Impala, so it is
basically ignored.
- added new default shuttle methods.
- removed a char/string conversion hack that was no longer needed.
- fixed a compatibility problem to ensure nullability for RelDataTypes
are equivalent.
- fixed a regression for the 'like' operator in 1.41. The Calcite jira
associated with this is CALCITE-7287 which has been fixed in 1.42. The
code needed to work around this regression is in RexCallConverter and
can be removed when Calcite 1.42 is released.
Change-Id: I0fde6381c04958d69f1bee13864c11c7cd385d29
---
M java/calcite-planner/pom.xml
M
java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java
M
java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java
M
java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexCallConverter.java
M
java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaOperatorTable.java
M
java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeCoercionImpl.java
M
java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeConverter.java
M
java/calcite-planner/src/main/java/org/apache/impala/calcite/validate/ImpalaConformance.java
M testdata/workloads/functional-query/queries/QueryTest/calcite.test
9 files changed, 108 insertions(+), 22 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/24043/3
--
To view, visit http://gerrit.cloudera.org:8080/24043
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0fde6381c04958d69f1bee13864c11c7cd385d29
Gerrit-Change-Number: 24043
Gerrit-PatchSet: 3
Gerrit-Owner: Steve Carlin <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
