Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24008 )
Change subject: IMPALA-14332: Add X-Request-Id as HttpRequestId attribute on root OTel span ...................................................................... Patch Set 4: (6 comments) Submitted the patch along with the changes of the patches for IMPALA-14370 http://gerrit.cloudera.org:8080/#/c/24008/3/be/src/observe/otel-test.cc File be/src/observe/otel-test.cc: http://gerrit.cloudera.org:8080/#/c/24008/3/be/src/observe/otel-test.cc@477 PS3, Line 477: > This test belongs in otel-trace-manager-test.cc (patch https://gerrit.cloud Done http://gerrit.cloudera.org:8080/#/c/24008/1/be/src/observe/span-manager.cc File be/src/observe/span-manager.cc: http://gerrit.cloudera.org:8080/#/c/24008/1/be/src/observe/span-manager.cc@147 PS1, Line 147: > Ah, I see now. In that case, it would be easier to call root_->SetAttribut Done http://gerrit.cloudera.org:8080/#/c/24008/3/tests/custom_cluster/test_otel_trace.py File tests/custom_cluster/test_otel_trace.py: http://gerrit.cloudera.org:8080/#/c/24008/3/tests/custom_cluster/test_otel_trace.py@475 PS3, Line 475: TCLIService.TStatusCode.SUCCESS_WITH_INFO_STATUS) > To keep consistent, since all other tests in here use 'assert_trace' as the Done http://gerrit.cloudera.org:8080/#/c/24008/3/tests/custom_cluster/test_otel_trace.py@477 PS3, Line 477: : # Run a GetColumns() operation. : get_cols_req = TCLIService.TGetColumnsReq( > This assertion needs to be done in otel_trace.py since that is where all sp Done http://gerrit.cloudera.org:8080/#/c/24008/3/tests/util/otel_trace.py File tests/util/otel_trace.py: http://gerrit.cloudera.org:8080/#/c/24008/3/tests/util/otel_trace.py@685 PS3, Line 685: eq > Nit: wrap with single quotes -- Expected: '{}', Actual: '{}' Done http://gerrit.cloudera.org:8080/#/c/24008/3/tests/util/otel_trace.py@705 PS3, Line 705: __assert_scopespan_common(init_span, query_id, False, "Init", expected_attr_count, > Need to also assert the value of the "HttpRequestId" attribute in the init Done -- To view, visit http://gerrit.cloudera.org:8080/24008 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e14f5b503ff7379463332bae34c266afc395524 Gerrit-Change-Number: 24008 Gerrit-PatchSet: 4 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Thu, 12 Mar 2026 04:33:47 +0000 Gerrit-HasComments: Yes
