Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24066 )
Change subject: IMPALA-14776 (part 3): Fix misc resource leaks ...................................................................... IMPALA-14776 (part 3): Fix misc resource leaks This fixes a variety of misc resource leaks and other warnings. This is purely about reducing the noise, so these are not fixing issues that would impact build stability. There are a few different categories: 1. Leaked open files - There are a couple locations that open /dev/null manually to use with subprocess. This switches them to subprocess.DEVNULL - Otherwise, use a context manager 2. Leaked thread pools - Manually call terminate at the end 3. Leaked processes - Add a wait() call after killing them 4. Warnings about deprecated pyparsing APIs - switched to the new API in db_connection.py 5. Warnings about invalid escapes - used raw strings for regex 6. Warnings from pytest failing to collect tests from TestLastDdlTimeUpdate's TestHelper - Renamed TestHelper to Helper so pytest doesn't try to find tests in it 7. A few minor socket leaks Testing: - Ran a core job Change-Id: Iee2c7733f477eadac7cde020b9aa47077985eb0d Reviewed-on: http://gerrit.cloudera.org:8080/24066 Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Csaba Ringhofer <[email protected]> Reviewed-by: Michael Smith <[email protected]> --- M tests/common/impala_test_suite.py M tests/comparison/db_connection.py M tests/custom_cluster/test_concurrent_ddls.py M tests/custom_cluster/test_local_catalog.py M tests/custom_cluster/test_shell_interactive.py M tests/custom_cluster/test_topic_update_frequency.py M tests/metadata/test_compute_stats.py M tests/metadata/test_ddl.py M tests/metadata/test_last_ddl_time_update.py M tests/performance/query_executor.py M tests/shell/test_shell_commandline.py M tests/shell/test_shell_interactive.py M tests/stress/stress_util.py M tests/util/auto_scaler.py M tests/util/compute_table_stats.py 15 files changed, 30 insertions(+), 13 deletions(-) Approvals: Impala Public Jenkins: Verified Csaba Ringhofer: Looks good to me, but someone else must approve Michael Smith: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/24066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Iee2c7733f477eadac7cde020b9aa47077985eb0d Gerrit-Change-Number: 24066 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]>
