Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24068 )

Change subject: IMPALA-13122 addendum: Fix host statistics logging for erasure 
coded files
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24068/1/fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java
File fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java:

http://gerrit.cloudera.org:8080/#/c/24068/1/fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java@134
PS1, Line 134: >=
This is confusing. If there are 3 block replicas located on 2 hosts (EC 
disabled), getNumUniqueHosts() is 2 and getNumUniqueHostDiskPairs() is 3. The 
test passes since the 3 replicas are on 3 different DataNodes. Let's remove 
this check since all results are possible.



--
To view, visit http://gerrit.cloudera.org:8080/24068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6f5b70fa9c46dd3f34287f030553360da6b20c6
Gerrit-Change-Number: 24068
Gerrit-PatchSet: 1
Gerrit-Owner: Arnab Karmakar <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Thu, 05 Mar 2026 01:23:14 +0000
Gerrit-HasComments: Yes

Reply via email to